Re: [PATCH] Default charset patch (bug 0000068)

Thanks!

Rune

---
Rune Sætre <[email protected]>
NetCom as, Infrastruktur
Telefon (mob): 934 34 285
..

On Tue, 15 Feb 2005, Stipe Tolj wrote:

> Rune Saetre wrote:
>
> > Hi again.
> >
> > I think this patch should be applied before 1.4.1 is released.
> >
> > I have submitted this before, but without the [PATCH] tag in the subject
> > line. And here it is again, since I cannot see it has been applied to the
> > CVS.
> >
> > This patches the gateway-1.4.0/gwlib/http.c file from the 1.4.0 version to
> > set ISO-8859-1 as charset for subtypes of "text" if no charset is
> > specified in the headers.
> >
> > This is in accordance with RFC 2616, section 3.7.1.
> > It also adresses bug #0000068.
> > Moreover, wapbox is totally useless without it here in Norway...
>
> applied to cvs, in a variation form. See
> http://www.kannel.org/cgi-bin/viewcvs.cgi/gateway/gwlib/http.c.diff?r1=1.225&r2=1.226&sortby=date
>
> On the other side, I'm asking myself if this shouldn't be the "job" of ther
> server side? Now, it seems like Apache2 does not check for this issue and
> provides a content-type header with text/... and non-set character encoding value.
>
> Rune, the text page you referenced did not work (like you stated with the
> libxml2 parsing error) before the cvs commit and does now.
>
> This also resolved bug #68.
>
> Stipe
>
> mailto:stolj_{at}_wapme.de
> -------------------------------------------------------------------
> Wapme Systems AG
>
> Vogelsanger Weg 80
> 40470 Düsseldorf, NRW, Germany
>
> phone: +49.211.74845.0
> fax: +49.211.74845.299
>
> mailto:info_{at}_wapme-systems.de
> http://www.wapme-systems.de/
> -------------------------------------------------------------------
>