[PATCH] incorrect assignment of DCS to deliver_sm instead of submit_sm in gateway/gw/smsc/smsc_smpp.c

Looking at the code to help another user with a alt-dcs problem, I
noticed the following in gateway/gw/smsc/smsc_smpp.c of the CVS version:

    /*
     * set the data coding scheme (DCS) field
     * check if we have a forced value for this from the smsc-group.
     * Note: if message class is set, then we _must_ force alt_dcs otherwise
     * dcs has reserved values (e.g. mclass=2, dcs=0x11). We check MWI flag
     * first here, because MWI and MCLASS can not be set at the same time and
     * function fields_to_dcs check MWI first, so we have no need to force alt_dcs
     * if MWI is set.
     */
    if (msg->sms.mwi == MWI_UNDEF && msg->sms.mclass != MC_UNDEF)
        pdu->u.deliver_sm.data_coding = fields_to_dcs(msg, 1); /* force alt_dcs */
    else
        pdu->u.submit_sm.data_coding = fields_to_dcs(msg,
            (msg->sms.alt_dcs != SMS_PARAM_UNDEFINED ?
             msg->sms.alt_dcs : smpp->conn->alt_dcs));

Shouldn't it be setting the DCS in the pdu->u.submit_sm.data_coding instead
of the deliver_sm?

Enclosed is a patch to resolve this issue.

See ya...

d.c.

Index: gateway/gw/smsc/smsc_smpp.c
===================================================================
RCS file: /home/cvs/gateway/gw/smsc/smsc_smpp.c,v
retrieving revision 1.77
diff -a -u -r1.77 smsc_smpp.c
--- gateway/gw/smsc/smsc_smpp.c	1 Feb 2005 19:57:54 -0000	1.77
+++ gateway/gw/smsc/smsc_smpp.c	17 Feb 2005 10:37:46 -0000
@@ -617,7 +617,7 @@
      * if MWI is set.
      */
     if (msg->sms.mwi == MWI_UNDEF && msg->sms.mclass != MC_UNDEF)
-        pdu->u.deliver_sm.data_coding = fields_to_dcs(msg, 1); /* force alt_dcs */
+        pdu->u.submit_sm.data_coding = fields_to_dcs(msg, 1); /* force alt_dcs */
     else
         pdu->u.submit_sm.data_coding = fields_to_dcs(msg,
             (msg->sms.alt_dcs != SMS_PARAM_UNDEFINED ?