Re: [PATCH] incorrect assignment of DCS to deliver_sm instead of submit_sm in gateway/gw/smsc/smsc_smpp.c

Hi Davy,

nice catch ;)

commited to cvs, Thanks!

Davy Chan wrote:

> Looking at the code to help another user with a alt-dcs problem, I
> noticed the following in gateway/gw/smsc/smsc_smpp.c of the CVS version:
> 
>     /*
>      * set the data coding scheme (DCS) field
>      * check if we have a forced value for this from the smsc-group.
>      * Note: if message class is set, then we _must_ force alt_dcs
>      otherwise * dcs has reserved values (e.g. mclass=2, dcs=0x11). We
>      check MWI flag * first here, because MWI and MCLASS can not be set at
>      the same time and * function fields_to_dcs check MWI first, so we
>      have no need to force alt_dcs * if MWI is set.
>      */
>     if (msg->sms.mwi == MWI_UNDEF && msg->sms.mclass != MC_UNDEF)
>         pdu->u.deliver_sm.data_coding = fields_to_dcs(msg, 1); /* force
>         alt_dcs */
>     else
>         pdu->u.submit_sm.data_coding = fields_to_dcs(msg,
>             (msg->sms.alt_dcs != SMS_PARAM_UNDEFINED ?
>              msg->sms.alt_dcs : smpp->conn->alt_dcs));
> 
> Shouldn't it be setting the DCS in the pdu->u.submit_sm.data_coding
> instead of the deliver_sm?
> 
> Enclosed is a patch to resolve this issue.
> 
> See ya...
> 
> d.c.

-- 
Thanks,
Alex