Re: [PATCH][RESEND][ANNOYANCE] Fix empty device_headers and small memory leak with connection-oriented wap

Paul P Komkoff Jr <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Organization Department of Fish & Wildlife
Message-ID <[email protected]>
Replying to Stipe Tolj:
> Paul P Komkoff Jr wrote:
> 
> >When I'll get tired of this ...
> 
> ok, Alex did the quick shoot and commited. Paul can you please point out 
> the semantical logic change you did here?! I don't get the point from your 
> previous quote:

What do you tink will happen with connection-oriented wap and request
being processed?

I know what.
request_headers will be null, and all Accept.*: information are in
session_headers.

Before this change, in such case, device_headers was made empty gwlist. And
none of following checks (for acceptable charset, for example)
succeeds. And, further, empty gwlist (device_headers) was never
destroyed.

Now I'm making device_headers by combining session and request
headers, and correctly destroying it afterwards.

> In order not to dive into too deep of this, a pointing out would be great. 
> Thanks in advance.

:(

-- 
Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key
 This message represents the official view of the voices in my head
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.