Re: [PATCH] Addition Of http-proxy-port-exceptions
Jonathan Houser <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Stipe,
> I've got it mostly written I think. I just remembered something,
> however, as I was trying to figure out why it was crashing. The other
> reason I wasn't going to use a regex is because the http_use_proxy()
> function that is called to see if proxy should be used is only passed
> the host. Thus you can't actually look for "https://" in say
> "https://mobile.msn.com/..." because all you'll get is "mobile.msn.com".
> Since this is how you want it to work, though, I'll have to work that
> in somehow I guess. As an aside, I added a gw_regex_duplicate()
> function as well while working on this.
Ok, my stupid gw_regex_duplicate() function was crashing it. Must
not be a simple memcpy sort of operation (ie. needs a deep copy). Damn.
Anyway, I've got the regex working now. I just added trans->url to
trans->host as being passed into http_use_proxy(). I'll have to go over
my changes with the usual fine tooth comb for idiot mistakes, and after
that I'll submit my http-proxy-exceptions-regex patch. However the
weekend hath arrived and I'm getting the hell outta here. :P
Jon