Re: [PATCH] Add missing wrapper function to pthread_cancel

Stipe Tolj <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Organization The Kannel Group
Message-ID <[email protected]>
Wilfried Goesgens wrote:

> pthread offers a function to forcibly end a thread. 
> 
> usefull if a thread is caught in blocking I/O which makes
> it freeze.

-1 on _this_ approach of gwthread_cancel(), due taht we don't handle here how 
the kannel thread data (threadinfo) is destroyed, etc.

Consider the attached (patched) test/test_wakeup.c that does not work with this 
simple gwthread_cancel() approach.

Stipe

mailto:stolj_{at}_wapme.de
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany

phone: +49.211.74845.0
fax: +49.211.74845.299

mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
-------------------------------------------------------------------
test_wakeup.c (text/plain, 3.6 KB)
/* ==================================================================== 
 * The Kannel Software License, Version 1.0 
 * 
 * Copyright (c) 2001-2005 Kannel Group  
 * Copyright (c) 1998-2001 WapIT Ltd.   
 * All rights reserved. 
 * 
 * Redistribution and use in source and binary forms, with or without 
 * modification, are permitted provided that the following conditions 
 * are met: 
 * 
 * 1. Redistributions of source code must retain the above copyright 
 *    notice, this list of conditions and the following disclaimer. 
 * 
 * 2. Redistributions in binary form must reproduce the above copyright 
 *    notice, this list of conditions and the following disclaimer in 
 *    the documentation and/or other materials provided with the 
 *    distribution. 
 * 
 * 3. The end-user documentation included with the redistribution, 
 *    if any, must include the following acknowledgment: 
 *       "This product includes software developed by the 
 *        Kannel Group (http://www.kannel.org/)." 
 *    Alternately, this acknowledgment may appear in the software itself, 
 *    if and wherever such third-party acknowledgments normally appear. 
 * 
 * 4. The names "Kannel" and "Kannel Group" must not be used to 
 *    endorse or promote products derived from this software without 
 *    prior written permission. For written permission, please  
 *    contact [email protected]. 
 * 
 * 5. Products derived from this software may not be called "Kannel", 
 *    nor may "Kannel" appear in their name, without prior written 
 *    permission of the Kannel Group. 
 * 
 * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED 
 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES 
 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 
 * DISCLAIMED.  IN NO EVENT SHALL THE KANNEL GROUP OR ITS CONTRIBUTORS 
 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,  
 * OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT  
 * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR  
 * BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,  
 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE  
 * OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,  
 * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 * ==================================================================== 
 * 
 * This software consists of voluntary contributions made by many 
 * individuals on behalf of the Kannel Group.  For more information on  
 * the Kannel Group, please see <http://www.kannel.org/>. 
 * 
 * Portions of this software are based upon software originally written at  
 * WapIT Ltd., Helsinki, Finland for the Kannel project.  
 */ 

#include <unistd.h>

#include "gwlib/gwlib.h"

static void thread1(void *arg) 
{
    pid_t pid;

	debug("test", 0, "Sleeping");
    pid = getpid();
    debug("test", 0, "Thread1 pid %ld", (long)pid);

	gwthread_sleep(600);
	debug("test", 0, "Woke up");
}

static void thread2(void *arg) 
{
    pid_t pid;

    debug("test", 0, "Sleeping");
    pid = getpid();
    debug("test", 0, "Thread2 pid %ld", (long)pid);

    gwthread_sleep(600);
    debug("test", 0, "Woke up");
}

int main(void) 
{
    pid_t pid;
    long t1, t2;
    int ret;
    
	gwlib_init();
    pid = getpid();
    debug("test", 0, "Parent pid %ld", (long)pid);
	t1 = gwthread_create(thread1, NULL);
    t2 = gwthread_create(thread2, NULL);
	sleep(1);
	gwthread_wakeup(t1);
    ret = gwthread_cancel(t2);
    debug("test", 0 ,"gwthread_cancel returns: %d", ret);
    gwthread_wakeup_all();
	gwthread_join_all();
	gwlib_shutdown();
   	return 0;
}
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.