Re: MC35i on a TCP terminal server -- patch now

Hi Alex,

--- Alexander Malysh <[email protected]> wrote:
> >>+        if (strcmp(octstr_get_cstr(privdata->device), "rawtcp") == 0) {
> >>+            privdata->fd =
> 
> don't use strcmp. you can use octstr_str_compare or 
> octstr_str_case_compare.

ok, will do.

> >>+        privdata->rawtcp_host = cfg_get(cfg, octstr_imm("rawtcp-host"));
> >>+        if (cfg_get_integer(&portno, cfg, octstr_imm("rawtcp-port")) ==

> why do you introduce new config variables? why not just reuse already 
> available 'host'/'port'?

because I thought it's inline with other syntax standards: there are 
already variables like bearerbox-host, or http-proxy-host specifying some 
remote entity. Besides, it's more explanative and tolerant to future 
features which may also refer to some host/port information.

Thanks,
Stanislav