Re: [PATCH] configurable max retries

Alexander Malysh wrote:

>> Index: gwlib/cfg.def
>> ===================================================================
>> RCS file: /home/cvs/gateway/gwlib/cfg.def,v
>> retrieving revision 1.112
>> diff -a -u -p -r1.112 cfg.def
>> --- gwlib/cfg.def    21 Sep 2005 02:01:22 -0000    1.112
>> +++ gwlib/cfg.def    26 Oct 2005 20:36:52 -0000
>> @@ -118,6 +118,8 @@ SINGLE_GROUP(core,
>>      OCTSTR(dlr-storage)
>>      OCTSTR(maximum-queue-length)
>>      OCTSTR(sms-incoming-queue-limit)
>> +    OCTSTR(sms-resend-frequency)
>> +    OCTSTR(sms-max-resend-retry)
>>  )

+1 on the logic, I assume you did regression test this Alex, did you?

I'm -1 on the new config directive naming, and I'd like to change it to:

   sms-resend-freq
   sms-resend-retry

Reasons:

'sms-resend-freq' follows naming convention as introduced to prior config 
directives 'store-dump-freq' within core group and 'timer-freq' for wapbox group

'sms-resend-retry' follows naming and semantical convention introduced via 
'http-request-retry' within smsbox group.

I'll change these and commit to cvs.

Stipe

mailto:stolj_{at}_wapme-group.de
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany

phone: +49.211.74845.0
fax: +49.211.74845.299

mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
-------------------------------------------------------------------