[RFC] gw/smsc/smsc_smpp.c commit to revision 1.85 (amalysh)

Hi Alex,

just reviewing your commit and I have some questions I'd like to hear comments ;)

* you safe an "empty" function to dump_pdu() via a #define that does a "useless" 
do loop. Has this been profiled via assembler generation that it is really a 
benefit against the existing version? Could do some quick tests on this.

* prototype for handle_dlr() changed in the sense that you pass the Octstr 
pointer et all to the function and not the SMPP_PDU pointer itself? Why? Makes 
the function prototype horrible long IMO.

* everyting else seems straight forward to me ;)

I'm not veto'ing, just want to hear about the "conceptual ideas" you have/had 
for the above two point.

Stipe

mailto:stolj_{at}_wapme-group.de
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany

phone: +49.211.74845.0
fax: +49.211.74845.299

mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
-------------------------------------------------------------------