Re: [PATCH] DLR with field_dst not supported in Mysql/Pgsql

Olivier Dormond wrote:
> Hello,
> 
> Alexander Malysh wrote:
> 
>>
>> Another thing that your patch not does, is the fact that we have two 
>> level unified prefix: one at SMSC level and another one at global 
>> level. Your patch seem not use global level unified prefix.
> 
> 
> Well, I must admit I have no clear mind about how the various
> unified_prefix are handled inside kannel. I just picked up the one
> attached to the connection.
> 
> Actually I don't understand what the unified_prefix of the core group
> is meant to be used for. Having one in the smsc to normalize the msisdn
> used when talking to the smsc and one in the smsbox group used to
> communicate with the external apps seems logical to me, but in the core...
> If it's supposed to be a way to provide a common value for both the smsc
> and the external app normalization than if should be put in each connection
> and be overridden if there is a unified_prefix specified in a given smsc
> group. That would save a check unless both unified_prefix are supposed
> to be applied in turn (but in that case, in which order to apply them?).
> 
> Of course, if I can get a clear picture of the situation I can update
> the patch accordingly.


just look how it works in the existing functions: 
gw/bb_smscconn::bb_smscconn_receive(...) line 383.

If not clear after that please ask.

> 
>> Another thing that I don't like is to not force SMSC modules to call 
>> unified_prefix function. IMO it would be better to extend dlr_find 
>> function with unified_prefix parameter and do all the magic in 
>> dlr_find function that then forces SMSC module to call unified_prefix.
> 
> 
> Ok. I just did that to avoid modifying two additional files (dlr.[ch]).
> Not really a good reason indeed :-)
> 
> Cheers,
> 
>             Olivier
>