Re: [PATCH] DLR with field_dst not supported in Mysql/Pgsql

Hello,

Alexander Malysh wrote:
>> Of course, if I can get a clear picture of the situation I can update
>> the patch accordingly.
> 
> just look how it works in the existing functions: 
> gw/bb_smscconn::bb_smscconn_receive(...) line 383.
> 
> If not clear after that please ask.

Ok, that's pretty clear but that won't help much. :-(

The global unified_prefix is inaccessible from the smsc. It need to be
fetched from the core group but all what the smsc sees during its life
is it's own CfgGroup.

The simplest thing might be to add a field to the SMSCConn struct to
hold the global unified prefix and give it to smscconn_create to fill
the field (or just set the value on the SMSCConn it returns in
smsc2_start).

I've checked all the place where normalize_number is called with the
global unified_prefix and it turns out it is only used in smsc2_rout
and in bb_smscconn_receive just after the smsc specific one.

I'm afraid that didn't convinced me it's worth doing all the burden
to apply both of them. I think it would really be much simpler to just
set the smsc specific unified_prefix to the global value as a fall back
mechanism in case the smsc group doesn't have one. But I admit it might
break present configuration which relies on both being applied in
bb_smscconn_receive.

What do you think ? Am I missing something ?

Cheers,

			Olivier

-- 
----------------------------------------------------------------------
Mobile News Channel                     Direct phone: +41 21 317 50 25
Olivier Dormond                         Central:      +41 21 317 50 20
Av. de la Gare 10
1003 Lausanne                           Email:          [email protected]