Re: Malformed addr for Incoming short code

Arne K. Haaje wrote:
> 
> However, nothing ended up in the access-log. Now, if you send an 
> outgoing message and it get's rejected you get (at least when using DLR) 
> a 16 NACK in the log. Why not use a line in the access-log when 
> *receiving* invalid messages as well?

This would imply we have a new gw/bb_smscconn.c:bb_smscconn_receive_failed() as 
we have for bb_smscconn_send_failed().

So within gw/smsc/smsc_smpp.c:handle_pdu() we would call the _receive_failed() 
at appropriate places with the "so long unpacked" PDU and destroy the message 
after we have the access.log writen.

BTW, reviewing the code here, I see a bug:

gw/smsc/smsc_smpp.c:1337:  if (pdu->u.deliver_sm.esm_class & (0x04|0x08)) {

where we process currently pdu->type == data_sm ?? this should be 
pdu->u.data_sm.esm_class here, right?

Stipe

-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------