Re: Shutdown races...

Hi,

this patch is also wrong. see below...

Thanks,
Alex

Wilfried Goesgens schrieb:
> Kannel should wait for all smsc's to terminate before shutting down store.
> else this will panic (especially with alexander malyshs store-dir)
> on shutdown, if the store is terminated fist.
> Please find a patch attached, that does a for loop over all available smsc's, 
> test if they're still valid, if, wait for them to become shut down, 
> and then continue to destruct kannel.
> 
> 
> 
> Wilfried G�sgens
> 
> 
> ------------------------------------------------------------------------
> 
> --- a/gateway/gw/bb_smscconn.c	2005-11-10 17:17:10.000000000 +0100
> +++ b/gateway/gw/bb_smscconn.c	2006-04-05 19:30:42.000000000 +0200
>  
> @@ -752,7 +711,7 @@
>  int smsc2_shutdown(void)
>  {
>      SMSCConn *conn;
> -    long i;
> +    long i,j;
>  
>      if (!smsc_running)
>          return -1;
> @@ -776,6 +735,13 @@
>       * to shutdown before calling these?
>       */
>      gwlist_remove_producer(incoming_sms);
> +	j=gwlist_len(smsc_list);
> +	for(i=0; i < j; i++) {
> +        conn = gwlist_get(smsc_list, i);
> +		smscconn_wait_shutdown_finished(conn);

I don't know any function with such name...

> +		info(0,"%li done. %li more to go.", i, j-i);
> +	}
> +
>      return 0;
>  }
>