Re: [PATCH] Internal charset

Hi,

I don't see how your patch should help with euro sign if SMSC supports only
GSM charset? and your patch is incomplete because it changes only SMPP
module.

What would be more suitable to support all GSM chars, is to switch internal
kannel charset to UTF-8. I have patch somewhere but it will take some time
to rebase it against current CVS and it's too intrusive (not 1.4.1
material).

For now it would be easy to keep latin1 as default but allow ESC (27) to go
through (in gwlib/charset.c change it from NRP to 27) and then you should
be able to send euro sign via sendsms interface.

Thanks,
Alex

Peter Christensen wrote:

> Hi,
> 
> At the request of Hillel, I have agreed to update my patch for the
> internal character set of smsbox/smpp, and post it here, hoping for it
> to be committed to CVS.
> 
> It:
> 
> * Changes the default 7-bit character set of smsbox to windows-1252
> instead of iso-8859-1, adding support for the euro-sign. (remember that
> the latin1/gsm conversion functions already assumes windows-1252)
> 
> * smsbox uses charset_convert instead of octstr_recode, because the
> latter will convert the euro-sign into a HTML entity.
> 
> * Changes the internal 7-bit character set of SMPP to windows-1252.
> 
> * Updates the documentation accordingly.
> 
> 
> The primary effect of this patch should be support for the € sign in
> both SMS transmission and reception (at least for gateways, which
> utilizes the latin1/gsm conversion functions). For the rest, this should
> have no effect since windows-1252 is identical to iso-8859-1 except for
> 0x80-0x9F which is unused in iso-8859-1.
> 
> Just to clarify: Unless the problem is in octstr_recode, this patch ONLY
> adds support for the € (euro) sign. Other characters such as £ (pound)
> also worked before. If a gateway didn't support £ before, it won't do it
> now either. Besides, this patch does NOT add support for Greek GSM
> characters!
> 

-- 
Thanks,
Alex