Re: [PATCH] sms-resend-retry error
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | tolj.org system architecture |
| Message-ID | <[email protected]> |
Mi Reflejo wrote:
>> From bug:
>
> http://bugs.kannel.org/view_bug_advanced_page.php?f_id=0000341
>
> Problem:
> Whenever there is submit_sm_resp failure, the submit_sm is going on
> endlessly, instead of N retries.
>
> Explanation:
> The problem exists because variable++ increments variable by one but
> returns always variable without the increment. so the line:
> sms->sms.resend_try = (sms->sms.resend_try > 0 ? sms->sms.resend_try++ :
> 1);
> is always setting sms->sms.resend_try to 1 or to sms->sms.resend_try
>
> Solution:
> With value+1instead the problem is fixed.
>
> Already tested and it's working.
>
> Attaching the PATCH.
>
> Regards,
> MartÃn Conte
+1, commited to cvs. Thanks a lot.
Also bug report resolved.
Stipe
-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany
tolj.org system architecture Kannel Software Foundation (KSF)
http://www.tolj.org/ http://www.kannel.org/
mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------