Re: Bug in smsc_at

Hi,

committed to cvs.

Thanks,
Alex

Andrija Petrovic schrieb:
> Version 30 is buggy, due to wrong condition for octstr_len(temp).
> Changed the condition...
> 
> Regards,
> Andrija
> 
> 
> ------------------------------------------------------------------------
> 
> ? gateway/gw/smsc/.smsc_at.c.swp
> Index: gateway/gw/smsc/smsc_at.c
> ===================================================================
> RCS file: /home/cvs/gateway/gw/smsc/smsc_at.c,v
> retrieving revision 1.30
> diff -u -b -B -a -u -r1.30 smsc_at.c
> --- gateway/gw/smsc/smsc_at.c	11 May 2006 14:40:37 -0000	1.30
> +++ gateway/gw/smsc/smsc_at.c	17 May 2006 12:40:35 -0000
> @@ -2649,7 +2649,7 @@
>  			    );
>  
>      /* grab the digits from the MSISDN and encode as swapped semi-octets */
> -    while (out != NULL && octstr_len(temp) >= 0) {
> +    while (out != NULL && octstr_len(temp) > 0) {
>          int digit1, digit2;
>          /* get the first two digit */
>          digit1 = octstr_get_char(temp,0) - 48;