Re: [PATCH] Typo in smsc_smpp.c
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | tolj.org system architecture |
| Message-ID | <[email protected]> |
Tom Sommer wrote:
> Nasty typo that's been there for years
>
> Basically BUFFRED -> BUFFERD
>
> Patch attached
>
> // Tom Sommer
>
>
> ------------------------------------------------------------------------
>
> --- org/kannel-snapshot/gw/smsc/smsc_smpp.c 2006-05-15 20:24:40.000000000 +0200
> +++ kannel-snapshot/gw/smsc/smsc_smpp.c 2006-05-29 14:28:17.000000000 +0200
> @@ -1231,7 +1231,7 @@
> dlrstat = DLR_SUCCESS;
> else if (stat != NULL && (octstr_compare(stat, octstr_imm("ACCEPTD")) == 0 ||
> octstr_compare(stat, octstr_imm("ACKED")) == 0 ||
> - octstr_compare(stat, octstr_imm("BUFFRED")) == 0 ||
> + octstr_compare(stat, octstr_imm("BUFFERD")) == 0 ||
> octstr_compare(stat, octstr_imm("ENROUTE")) == 0))
> dlrstat = DLR_BUFFERED;
> else
Hi Tom,
yep, +1 from my side, this seems a obvious typo.
Even while this is not included in the example section of appendix B of SMPP
v3.4 spec, I'm +1 for fixing this.
Anyone having objections? I don't hope someone tailored a SMPP server according
to this, so they break ;)
Stipe
-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany
tolj.org system architecture Kannel Software Foundation (KSF)
http://www.tolj.org/ http://www.kannel.org/
mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------