Re: [PATCH] (quasi) non-persistent SMPP - Non solicited feature

Hi,

it would be interresting to know the rationale of this patch better to say
requirements for XXX SMSC?

Josh McAllister wrote:

> This patch adds the ability to set smpp connection idle limits, and max
> submits per connection. This is a requirement for Sprint's SMSC.
> 
> Adds 2 smsc group config directives:
> sms-max-submits
> and
> sms-max-idle
> 
> The patch does not change existing behavior if these are not set, or set
> to 0. If sms-max-submits is set, it will shutdown the connection (unbind
> / wait for unbind_resp / etc) once we've submitted sms-max-submits
> messages, and immediately re-connect. Likewise, sms-max-idle will
> shutdown and immediately reconnect if we have submitted no messages in >
> sms-max-idle seconds.
> 
> Note: the test for max-idle will not be executed while we're sitting
> around doing nothing, so make sure that enquire-link-interval is set to
> some number < max seconds you can be late disconnecting. In other words,
> if sms-max-idle is 30 seconds, and enquire-link-interval is 30 seconds,
> it could be 1 minute before we disconnect.
> 
> This is my first patch submission so please be gentle... but of course
> feedback is appreciated.
> 
> Thanks,
> 
> Josh McAllister

-- 
Thanks,
Alex