RE: [PATCH] config definition file hooking (for external modules), ie. sqlbox, mbuni, etc.

-1 from me.

Reason 1:

Does this mean add-ons need to temporarily use an interim API and switch to
another API when it becomes available?

Reason 2:

mBuni, sqlbox require patches to the Kannel sources either way.
It doesn't matter if such patches also patch cfg.def or not.

Rene Kluwen
Chimit


-----Original Message-----
From: [email protected] [mailto:[email protected]]On
Behalf Of Stipe Tolj
Sent: zondag 11 juni 2006 19:21
To: Stipe Tolj
Cc: Kannel Development list
Subject: Re: [PATCH] config definition file hooking (for external
modules),ie. sqlbox, mbuni, etc.


Stipe Tolj wrote:

> Hi list,
>
> now, as Kannel maintains its own way of "knowing" what config directives
> are allowed in group sections, this is a problem if external modules,
> ie. Rene's sqlbox or Paul's Mbuni need to use the same gwlib/cfg.[ch]
> thingies.
>
> I tried to introduce a generic hooking mechanism for the 2 functions
> is_allowed_in_group() and is_single_group() that use the #include
> "cfg.def" for the core.
>
> Now extenal modules can use cfg_add_hooks(void *a, void *b) to offer
> their own "version" of these 2 routines and hence #include
> "foobar-cfg.def" in their own code space.
>
> The hooks are appended to a list and a wrapper loops arround the
> functiokns in the lists to get a boolean value.
>
> I know that this is not the most elegant way. Alex suggested using
> dlopne() and dlsym(), which are of course a "better" approach, but still
> we need to "concatenate" the defined groups and I had no idea how to do.
>
> Please review and vote.

no objectsion from the others?...

I'm going to commit this to cvs, even while Alex means there are more
elegant
ways to solve this. I agree. When using a cleaner API for add-on boxes this
should go away, but until then it shows-up to be usable and hence considered
as
add-on (non behaviour change) commit.

Stipe

-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------