Re: enquirelink patch

Denis V. Gudtsov wrote:

> Hello!
> 
> I wrote a little patch for kannel wich doesn't send keep-alive packets 
> (enquire link) if any other packets goes thorought gateway due to 
> enquire-link-interval.
> 
> 
> ------------------------------------------------------------------------
> 
> Index: gateway/gw/smsc/smsc_smpp.c
> ===================================================================
> RCS file: /home/cvs/gateway/gw/smsc/smsc_smpp.c,v
> retrieving revision 1.95
> diff -u -u -r1.95 smsc_smpp.c
> --- gateway/gw/smsc/smsc_smpp.c	13 Jun 2006 13:50:49 -0000	1.95
> +++ gateway/gw/smsc/smsc_smpp.c	25 Aug 2006 14:56:15 -0000
> @@ -78,7 +78,7 @@
>  #include "sms.h"
>  #include "dlr.h"
>  
> -#define SMPP_DEFAULT_CHARSET	"windows-1252"
> +#define SMPP_DEFAULT_CHARSET	"windows-1251"
>  
>  /*
>   * Select these based on whether you want to dump SMPP PDUs as they are
> @@ -1787,6 +1787,7 @@
>              send_enquire_link(smpp, conn, &last_enquire_sent);
>  
>              while ((ret = read_pdu(smpp, conn, &len, &pdu)) == 1) {
> +		last_enquire_sent = last_response;
>                  last_response = time(NULL);
>                  /* Deal with the PDU we just got */
>                  dump_pdu("Got PDU:", smpp->conn->id, pdu);

why is the assign BEFORE taking the current time taking place? Wouldn't this 
make more sense AFTER the time(NULL) asign?

Stipe

-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------