Re: [PATCH] DLR in EMI/UCP are not decoded to latin1

I agree on the added line

             charset_gsm_to_latin1(msg->sms.msgdata);

as this is most probably the right way to do (but has no effect on  
english default DLR messages 90% of the EMI/UCP SMSC's seem to return)

             /* obey the NRC (national replacement codes) */
             if (privdata->alt_charset == EMI_NRC_ISO_21)
                 charset_nrc_iso_21_german_to_gsm(msg->sms.msgdata);

especially, why is it german only as you probably more look towards  
the french side...


On 05.09.2006, at 11:46, Vincent CHAVANIS wrote:

> No objections here ?
>
> regards
>
> Vincent
>
> --
> Telemaque - 06200 NICE - (FR)
> Service Technique/Reseau - NOC
> Developpement SMS/MMS/Kiosques
> http://www.telemaque.fr/
> [email protected]
> Tel : +33 4 93 97 71 64 (fax 68)
> ----- Original Message ----- From: "Vincent CHAVANIS"  
> <[email protected]>
> To: <[email protected]>
> Sent: Friday, August 18, 2006 12:47 PM
> Subject: [PATCH] DLR in EMI/UCP are not decoded to latin1
>
>
>
> DLR msgdata in EMI/UCP smsc are not decoded.
> When a char with an accent arrives to a DLR like "MSISDN porté"
> It will not decode the msg and will result in a non-printable char.
> IA5 charset can handle these chars as when we are receiving an MO.
> We simply obey the NRC (if needed), then convert it to latin1.
>
> regards
>
> Vincent.
>
> --
> Telemaque - 06200 NICE - (FR)
> Service Technique/Reseau - NOC
> Developpement SMS/MMS/Kiosques
> http://www.telemaque.fr/
> [email protected]
> Tel : +33 4 93 97 71 64 (fax 68)
>
>
>