Re: [Fwd: [PATCH] smpp smsc throttling]

I need that we have to think about a global resolution of this issue.
The patch i've submited for emi/ucp smsc need to be implemented
in a higher level than inside the smsc driver.

Vincent.

----- Original Message ----- 
From: "Stipe Tolj" <[email protected]>
Cc: "Kannel Development list" <[email protected]>
Sent: Friday, September 29, 2006 3:17 PM
Subject: Re: [Fwd: [PATCH] smpp smsc throttling]


>> All,
>>
>> I was performing some checks on smpp throttling and found the same 
>> behaviour as vincent found below but this time in smsc_smpp.c.
>>
>> Specific behaviour I found was that I could dump a load of messages into 
>> the queue and while there was no further activity the queue would drain 
>> at the required throttling rate, however the moment extra activity 
>> started, e.g receiving more messages, the throttling behaviour went out 
>> the window and messages started draining at a much faster rate due to the 
>> gwthread_sleep poll function exiting short of the required timeout.
>>
>> I made a similar change to the code which appears to now provide correct 
>> throttling behaviour.
>>
>> Just wondering if there is a better place to put this as I suspect the 
>> gwthread_sleep problem will be seen in all smsc adapters.
>>
>> I've attached a patch for the code change.
>> The code base is the CVS code set from July 27.
>>
>> Stuart.
>
> anyone reviewed and voted for this patch?
>
> Stipe
>
> -------------------------------------------------------------------
> Kölner Landstrasse 419
> 40589 Düsseldorf, NRW, Germany
>
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
>
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> -------------------------------------------------------------------
>
>