Re: Compiling kannel with -Wall option

Andreas Fink wrote:

> We did that once for our own application which is using gwlib.
> Its just a lot of hand work and quite a few typecasts.
> 
> One problem spotted while doing that is that gwlib is never sure if  an 
> octet from an octetstring should be considered a signed char or a  
> unsigned char. My personal view is that it should be considered  
> unsigned char as we often use raw bytes in octstr. This however means  
> that whenever you do something like
> 
> debug("xx",0,"This is a string %s",octstr_get_cstr(xyz));
> 
> you have to typecast it to:
> 
> debug("xx",0,"This is a string %s",(char *)octstr_get_cstr(xyz));
> 
> 
> One thing which is new in GCC is that we have now 3 types of chars.
> 
> 
> char             (compiler default signedness)
> unsigned char
> signed char
> 
> And if the compiler default is signed char, you still get an error  when 
> you assign a signed char to char.
> Thats where 99% of the errors come from.

ok, so we could fix those warnings pretty simple then?

Stipe

-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------