Re: configurable max retries forgotten in 1.41 =(
"Alexander Malysh" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, yep, you are right we must fix it. But we should think of all possible implications and fix it right. I will try to fix it right... Thanks, Alex Am 18.10.2006, 22:58 Uhr, schrieb Dziugas Baltrunas <[email protected]>: > Hi, > > when I replied to your post, I was referring to your thread regarding > resend_try and sms_resend_frequency for split messages in particular: > > http://www.mail-archive.com/[email protected]/msg05943.html > > This has been never fixed until now even if we have separate threads > for the same issue on the mailing list. > > @Stipe, @Alex? > > On 10/18/06, Josh McAllister <[email protected]> wrote: >> Actually I have to eat some serious crow here. I checked out 1.41 >> instead of 1.4.1 and did a quick scan of the src for evidence of the >> patch and of course it wasn't in there. Got the appropriate 1.4.1 and it >> IS of course in there. Sorry for the false alarm. =/ Perhaps this should >> be highlighted in the Changes file though.? >> >> Thanks for getting it in! >> >> Josh >> >> > -----Original Message----- >> > From: Dziugas Baltrunas [mailto:[email protected]] >> > Sent: Wednesday, October 18, 2006 7:59 AM >> > To: Josh McAllister >> > Cc: Kannel Devel >> > Subject: Re: configurable max retries forgotten in 1.41 =( >> > >> > Hi, Josh, >> > >> > I completely agree with you. This never ending retry mechanism is not >> > only flooding logs, but also causing tons of problems for those >> > involved in maintenance of SMSCs or SMPP servers. >> > >> > There is also one similar thread together with the bug report >> > "pending", you may take a lot at it here: >> > >> > http://www.mail-archive.com/[email protected]/msg06060.html >> > >> > I would suggest to at least fix it in a "dirty" fashion rather then >> > waiting months for an "elegant" solution. >> > >> > On 10/17/06, Josh McAllister <[email protected]> wrote: >> > > >> > > To be frank, I'm amazed that this issue hasn't gotten more attention >> > > over the years given the default behavior of retrying immediately, >> and >> > > indefinitely. I don't know of any SMSC's that take kindly to that >> kind >> > > of behavior. >> > > >> > > I proposed a patch back in 7/05 that fixed this for smpp, followed >> by a >> > > more appropriate patch submitted (10/26/05) and later committed >> > > (11/8/05) by Alexander Malysh that fixed the problem for all protos. >> > > >> > > Is there a consensus that this is a critical issue? How is not a >> > > critical issue? What are the chances that we can get another release >> in >> > > the very near future? >> > > >> > > As always kudos to the devs, this really is a monster of a project. >> So >> > > many modalities, I can only imagine how difficult it is to keep up >> with >> > > it all. >> > > >> > > Josh McAllister >> > > >> > > >> > > > -----Original Message----- >> > > > From: Hillel [mailto:[email protected]] >> > > > Sent: Friday, October 06, 2006 4:53 AM >> > > > To: Kannel Devel >> > > > Cc: [email protected] >> > > > Subject: 3 patches seem to be forgotten >> > > > >> > > > Hi, >> > > > >> > > > There are 3 patches that seem to be forgotten and we were wondered >> if >> > > they >> > > > can be added: >> > > > >> > > > 1)Noor Entertainment [[email protected]] sent in on >> Date: >> > > Wed, >> > > > 12 >> > > > Jul 2006 02:35:43 -0700 (PDT) >> > > > " Please find attached a small patch against >> > > > gateway/gw/wap_push_ppg.c allowing to set the Wap Push >> > > > sender by using the 'X-Kannel-From' HTTP header when >> > > > submitting the Wap Push request to the Kannel PPG" >> > > > >> > > > It was not sent with the word PATCH in front so maybe it was >> missed. >> > > > >> > > > 2)Colin Pitrat <[email protected]> sent in a patch and then >> > > refered to >> > > > it again on Date: Mon, 02 Oct 2006 10:24:40 +0200 >> > > > Subject: Re: [PATCH] empty SMS replaced by default message >> > > > >> > > > This can be useful if you need to send an empty SMS to a customer. >> > > > >> > > > 3)"Alexander Malysh" <[email protected]> sent in an awesome patch >> on >> > > > Date: >> > > > Thu, 13 Jul 2006 21:35:37 +0200 with the Subject: [PATH] convert >> > > internal >> > > > charset to UTF-8. Becides the few changes from Peter this would >> be >> > > great >> > > > to >> > > > have in CVS, as it allows all the possible charset values. >> > > > >> > > > >> > > > Rgds >> > > > >> > > > >> > > > >> > > >> > > >> > > >> > > >> > >> > >> > -- >> > Dziugas >> >> >> > > -- Thanks, Alex