Re: [STATUS] Kannel 1.4.1 stable release

Hi,

this patch seems to be broken in all areas. Stipe? what should this patch  
do?
1) I don't like call bb_alog_sms from smsc module, it's up to smsc layer
2) even if all agreeing with (1) it's incomplete because handle only  
data_sm pdu
3) msg->sms.charset should go away because we have _always_ internal  
charset UTF-8
4) we didn't see this patch posted to ML and it changed behavior

I'm vote ++1 for reverting this patch.

Thanks,
Alex

Am 25.10.2006, 11:23 Uhr, schrieb Dziugas Baltrunas <[email protected]>:

> Hi again,
>
> I was incorrect saying about NEWS of 1.4.1, since rev. was made after
> a release and does not have stable_1_4_1 tag. However, this is still
> going to affect those who are using CVS HEAD.
>
> Regards,
> Dziugas Baltrunas
>
> On 10/25/06, Dziugas Baltrunas <[email protected]> wrote:
>> Hi Stipe,
>>
>> I noticed that one serious change wasn't even mentioned in the NEWS  
>> file.
>>
>> Since 1.96 rev. of gw/smsc/smsc_smpp.c, if no charset was given in
>> sendsms, we are transmitting submit_sm short_message to SMSC coded in
>> SMPP_DEFAULT_CHARSET which by now is "windows-1252":
>>
>> http://cvs.kannel.org/cgi-bin/viewvc.cgi/gateway/gw/smsc/smsc_smpp.c?r1=1.95&r2=1.96
>>
>> Earlier, in case of dcs = 0 or dcs & 0xF0, we were always converting
>> it to GSM 03.38. Hence for those who did an upgrade characters like
>> '@' will no longer work.
>>
>> Regards,
>> Dziugas Baltrunas
>>
>> On 9/25/06, Stipe Tolj <[email protected]> wrote:
>> > The Kannel Group is pleased to announce the availability of Kannel  
>> 1.4.1 stable
>> > release via it's web site at URL
>> >
>> >   http://www.kannel.org/download.shtml
>> >
>> > Please find attached the NEWS file section for release 1.4.1 stable.
>> >
>> > Stipe
>> >
>> > -------------------------------------------------------------------
>> > Kölner Landstrasse 419
>> > 40589 DÃŒsseldorf, NRW, Germany
>> >
>> > tolj.org system architecture      Kannel Software Foundation (KSF)
>> > http://www.tolj.org/              http://www.kannel.org/
>> >
>> > mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
>> > -------------------------------------------------------------------
>> >
>> >
>> > NEWS about Kannel: Open Source WAP and SMS Gateway version 1.4.1
>> >
>> > This is a STABLE version. It should be usable for production systems.
>> > Please do report problems to the Kannel bug tracking system available  
>> at
>> > http://bugs.kannel.org/ or send a mail to <[email protected]> (the  
>> development
>> > mailing list).
>> >
>> >
>> > Changes since version 1.4.0:
>> >
>> > [*** Beware that the version move from 1.4.0 to 1.4.1 contains more  
>> then 200
>> > changesets, with major bugfixes and improvemnts. Following is a  
>> summary of the
>> > main issues. For a complete and detailed set of changes please refer  
>> to the
>> > specific ChangeLog in the doc/ directory of the distribution. ***]
>> >
>> > Compatibility breakers:
>> >
>> >  * Format for wapbox's access-log format changed to include the  
>> MSISDN of
>> >    a client as second argument after client IP and before method.
>> >
>> >  * fakesmsc uses now -r to specify the remote port on bearerbox side.  
>> Option
>> >    -p is generally reserved for pid file creation.
>> >
>> >  * sendsms now obeys bearerbox's reply before indicating result to  
>> HTTP
>> >    caller. This breaks any application layer clients that rely on the  
>> HTTP
>> >    body response of sendsms. To enforce the old behaviour use config
>> >    directive 'immediate-sendsms-reply = true' in smsbox group.
>> >
>> >  * DLR via MySQL uses now also 'username' and 'password' for the
>> >    mysql-connection group in order to harmonize the config names.
>> >
>> > New features:
>> >
>> >  * Added config directive 'store-dump-freq' to core group to define  
>> the
>> >    fequency of the store-file dumping mechanism.
>> >
>> >  * Added backtrace support for Linux. In case of PANIC, we get a  
>> backtrace
>> >    of the called routines to make debugging easier.
>> >
>> >  * Added some new modem groups to doc/examples/modems.conf.
>> >
>> >  * Added more WTAI functions to support.
>> >
>> >  * Added RAW TCP support for remote termnial servers for AT modem  
>> devices.
>> >
>> >  * Added 'config.nice' support while configure time, to allow  
>> "remembering"
>> >    the used configure flags and options.
>> >
>> >  * Added OMA ProvCont support via OTA messages.
>> >
>> >  * Added SyncML support via OTA messages.
>> >
>> >  * Added directive 'wml-strict' to wapbox group.
>> >
>> >  * SMPP data_sm PDUs are supported now for MO messages.
>> >
>> >  * SMPP added config directives 'bind-addr-ton' and 'bind-addr-npi'  
>> to allow
>> >    setting values for bind_receiver and/or bind_transmitter PDUs.
>> >
>> >  * Added support for WSP 1.6 headers.
>> >
>> >  * Added automatic support for large files, via compiler directives.
>> >
>> >  * Added config line delimiter via \ (backslash). This allows  
>> wrapping config
>> >    lines to several lines.
>> >
>> >  * Added support for hooking config group definition files as our own
>> >    gwlib/cfg.def from external add-on modules to the core. Main  
>> intention is
>> >    to provide a installed Kannel without the need of patching the  
>> source for
>> >    any modules that use Kannel's gwlib and gw libs.
>> >
>> >  * Added config directives 'bearerbox-port' and 'bearerbox-port-ssl'  
>> to
>> >    smsbox group, in order to not need any core group reading of  
>> external
>> >    modules, ie. sqlbox.
>> >
>> >  * Added config directive 'max-pending-requests' for smsbox group to  
>> control
>> >    the outbound requests stream generated from smsbox towards HTTP
>> >    application servers.
>> >
>> > Bugfixes:
>> >
>> >  * Fixed several bugs in TCP connection handling.
>> >
>> >  * Fixed several bugs in HTTP communication layer.
>> >
>> >  * Fixed segfaults on x86_64 (Intel Xeon) platforms.
>> >
>> >  * SMPP validity and defer time are set in UTC, several improvements  
>> and
>> >    error checks added.
>> >
>> >  * Fixed several 'make check' issues.
>> >
>> >  * MySQL support fixed, where certain function prototype names clashed
>> >    with our own gwlist structure.
>> >
>> >  * DLR support for PostgreSQL fixed for LIMIT clause usage.
>> >
>> >  * WSP empty header values fixed.
>> >
>> >  * WDP fix to discard truncated datagrams without PANIC.
>> >
>> >  * WAP Cookie handling fixed, charset handling generalized.
>> >
>> >  * AT driver fixes and improvements.
>> >
>> >  * RADIUS bug fixed in MD5 computing for authentication towards NAS.
>> >
>> >  * MacOS X support improved for configure process.
>> >
>> >  * store-file fixes and improvements.
>> >
>> >  * WML compiler fix, causing sefault.
>> >
>> >  * Fixed memory leaks for concat message handling.
>> >
>> >  * MIME parsing and handling fixed.
>> >
>> >  * FreeBSD AMD64 architecture support fixed.
>> >
>> >  * Fixed wapbox signal handling for shutdown.
>> >
>> >  * WTP SAR race condition and handling fixed.
>> >
>> >  * Fixed memory leaks in smsbox.
>> >
>> >  * sendsms POST XML handling fixed, where sender address was not  
>> parsed.
>> >
>> >  * smsbox reply handling fixed, to copy the originating smsc-id value
>> >    in the reply messages.
>> >
>> >
>> >
>> >
>>
>
>



-- 
Thanks,
Alex