Re: Patch to resolve out of order messages on retry to smsbox

Hi,

seems you are right here. I will commit your patch today.

Am 02.11.2006, 14:21 Uhr, schrieb Ben Suffolk <[email protected]>:

>> the first question is, why retry heppens? smsbox crashed?
>
> Yes suppose for instance smsbox is not running, but messages come into  
> bearerbox from the smsc. The queue in bearerbox and get sent as soon as  
> smsbox connects.
>
>> As to the patch: this patch will not work as expected. It's  
>> intentinally that we put message at the end of the queue because we  
>> want to go through the whole queue. I don't see how it should work with  
>> your patch.
>
> What happens is the loop runs every 60 seconds, and on each run what was  
> happening was that each message was being tried once, then the first  
> message was tried again and put at the end of the list.
>
> This patch means each message is tried once as before, but the first  
> message is not tried a second time, and is not moved to the end of the  
> list.
>
> So the list order is preserved, so when the next run happens, after 60  
> seconds, the list is processed again, but still in the right order.
>
> Regards
>
> Ben
>
>
>



-- 
Thanks,
Alex