Re: [PATCH] setting the Wap Push sender

Andreas Fink wrote:

> just read the original patch and I have two questions:
> 
> a) why is this line there:
> 
>     http_header_remove_all(push_headers, "X-Kannel-From");
> 
> as the header is passed on as pointer, I don't see why it should  remove 
> something from it.
> 
> b) it should also support passing &from=... in the URL, not just the  
> X-Kannel-Header.
> 
> Otherwhise I don't see anything wrong with adding it.

true claims from Andreas here...

Juan, can you please resolve these aspects Andreas mentioned against current 
CVS, so we can re-review and commit the extentions to CVS.

Thanks in advance.

Stipe

-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------