Wap Push sender patch clarifications

Hello all,

Please find below clarifications regarding the wap
push sender patch questions raised at
http://www.kannel.org/pipermail/devel/2006-November/000587.html

> a) why is this line there:
>	http_header_remove_all(push_headers,
"X-Kannel-From");

> as the header is passed on as pointer, I don't see
why it should remove something from it.

I can only clarify why I put the line there.
I noticed that the http_header_remove_all is called
for all other X-Kannel headers in
'remove_x_kannel_headers'. I thought the same should
be done for the new 'X-Kannel-From' header. And I did
not add that to the 'remove_x_kannel_headers' because
the 'X-Kannel-From' header is inspected through
calling the 'handle_push_message' which comes two
lines _after_ calling 'remove_x_kannel_headers' in the
'pap_request_thread' function.
If you'd be able to clarify how this should be done, I
probably should be able to fix this.


> b) it should also support passing &from=... in the
URL, not just the X-Kannel-Header.

The reason why I did not add the 'from' as a CGI
variable in the URL, is that the Kannel PPG seems to
only support  'username' and 'password' as CGI
variables. Other PPG X-Kannel headers do not seem to
have CGI variables counterparts either. Yet, I
inspected how this can be done, and it seems to me a
bit difficult to implement this addition. I clarified
this is in
http://www.kannel.org/pipermail/devel/2006-July/000080.html

Thanks and regards,

Christian Boustany
Noor Entertainment, LLC



 
____________________________________________________________________________________
Sponsored Link

$420k for $1,399/mo. 
Think You Pay Too Much For Your Mortgage? 
Find Out! www.LowerMyBills.com/lre