Re: latin1 again in charset.c ???
"Alexander Malysh" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Andreas, you are right about gwlib that this is generic library. But why should this library include broken by design functions? It's just impossible to convert GSM to latin1 w/o loss so why include such functions? Am 08.01.2007, 14:32 Uhr, schrieb Andreas Fink <[email protected]>: > I think as gwlib is a generic lib, the functions should stay there even > kannel doesnt use it directly at the current time. > > On 08.01.2007, at 14:25, Alexander Malysh wrote: > >> Hi, >> >> Stipe, could you please explain this commit? Why we should care of any >> external boxes? If your external box needs these functions then please >> add those to files in your extenal box. >> >> I'm --1 for such overloading of libraries. >> >> +2007-01-07 Stipe Tolj <stolj at kannel.org> >> + * gwlib/charset.[ch]: re-add prototypes and function >> charset_latin1_to_gsm() >> + and charset_gsm_to_latin1() for the sake of backward >> compatibility of >> + external boxes using Kannel core libs. This should be reviewed >> and merged >> + into single array for latin1 and utf-8 transcoding values. >> >> >> P.S. Whixh boxes need these functions? >> >> --Thanks, >> Alex >> > > > -- Thanks, Alex