Re: [PATCH] bb_boxc retry on ack_failed_tmp (was Re: smsbox to bearerbox ack / nack)
Ben Suffolk <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Alex, Patch looks good, I've tested on my development servers and its working very well. Thank You. So thats a vote from me on a commit. (is that +1 I should say? I never quite followed how the voting is supposed to work) Regards Ben On 19 Jan 2007, at 16:47, Alexander Malysh wrote: > Hi Ben, > > attached simple patch implements resend of MO/DLR messages if some > box sent nack with ack_failed_tmp status. > > Comments please? > > Am 18.01.2007, 11:50 Uhr, schrieb Ben Suffolk <[email protected]>: > >> Thanks Alex >> >> It will be most useful to have it in place. >> >> Regards >> >> Ben >> On 17 Jan 2007, at 10:15, Alexander Malysh wrote: >> >>> Hi Ben, >>> >>> no sorry, I did not managed to do it. I will try to do it this week. >>> >>> Am 17.01.2007, 10:48 Uhr, schrieb Ben Suffolk <[email protected]>: >>> >>>>> no you miss the point. ack_success and ac_failed are the final >>>>> states and therefor bearerbox drops these messages from the >>>>> store and queue. When I commited this patch I told that it >>>>> misses ack_failed_tmp that is used for the purpose you >>>>> describe. That means when bearerbox receive ack with >>>>> ack_failed_tmp (temporarely) bearerbox will then do retry for >>>>> this message. >>>>> I will try to merge this bit this week. >>>> >>>> Hi Alex, >>>> >>>> Just wondering if you managed to merge in the code for the retry >>>> from bearerbox to smsbox when smsbox responds with ack_failed_tmp? >>>> >>>> Regards >>>> >>>> Ben >>>> >>>> >>>> >>>> >>> >>> >>> >>> --Thanks, >>> Alex >>> >>> >> >> >> > > > > -- > Thanks, > Alex > <bb_boxc-tmp-nack.patch> Ben Suffolk CTO Zygo Communications Switchboard: + 44 (8) 444 999 555 Mobile: +44 (0)7973 369097 Email: [email protected] This e-mail including any attachments is confidential and may be legally privileged. If you have received it in error please advise the sender immediately by return email and then delete it from your system. The unauthorised use, distribution, copying or alteration of this email is strictly forbidden. If you need assistance please contact us on + 448444 999 555