RE: Race condition in list_consume()

Hi,

it's already in mantis for a year already. I opened a bug as I fixed
bearerbox issue.

Raul Igrisan wrote:

> It is a great ideea to first add it to bug tracking list.
> 
>  
> 
> The sum is not to call functions which imply synchronization from the
> signal handler.
> 
> Those are debug()/warning()/etc and log_reopen() which indeed are in the
> application but in turn are calling gwlib/pthreads synchronization
> functions.
> 
>  
> 
> Bearerbox handles signals by setting a flag when receiving the signal in
> order to process it synchronously. Btw… shouldn’t it use
> atomic/interlocked primitives when setting the flag?
> 
>  
> 
>  
> 
>  
> 
>   _____
> 
> From: Andreas Fink [mailto:[email protected]]
> Sent: 17 April 2007 18:44
> To: Stipe Tolj
> Cc: Raul Igrisan; 'devel Devel'
> Subject: Re: Race condition in list_consume()
> 
>  
> 
> the sum is
> 
>  
> 
> dont call debug(), warning(), info() etc while being in a signal handler.
> 
> Now this is not in gwlib but in the application.
> 
>  
> 
> My application had a signal handler out of the model of bearerbox but it
> might be me who added info() there.
> 
> So we have to check how the *box signal handlers look like.
> 
>  
> 
>  
> 
>  
> 
> On 17.04.2007, at 17:41, Stipe Tolj wrote:
> 
> 
> 
> 
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> 
> Hash: SHA1
> 
>  
> 
> Raul Igrisan wrote:
> 
>  
> 
> My pleasure :-)
> 
>  
> 
> Now this issue might happen in smsbox and wapbox because they call
> gwlib/log
> 
> from the signal handlers as opposed to the bearer box which properly
> handles
> 
> the signals.
> 
>  
> 
> Would anyone address this issue and commit the fix to CVS?
> 
>  
> 
> yep, I would, can you please sum up the issue.
> 
>  
> 
> I'd also be +1 for adding this first to the bug tracking system, so we
> have a
> 
> track/log of the issue, since this is critical.
> 
>  
> 
> Stipe
> 
>  
> 
> - -------------------------------------------------------------------
> 
> Kölner Landstrasse 419
> 
> 40589 DÃŒsseldorf, NRW, Germany
> 
>  
> 
> tolj.org system architecture      Kannel Software Foundation (KSF)
> 
> http://www.tolj.org/              http://www.kannel.org/
> 
>  
> 
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> 
> - -------------------------------------------------------------------
> 
> -----BEGIN PGP SIGNATURE-----
> 
> Version: GnuPG v1.4.7 (MingW32)
> 
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
>  
> 
> iD8DBQFGJOqj9ez0oeKvYs0RAlQqAJ9qVDD0u+ZFfx7tPk7FvasQTnEMvQCfdpAi
> 
> aaS3ak861byGN5UYtq6y5a4=
> 
> =Do4L
> 
> -----END PGP SIGNATURE-----
> 
>  
> 
>  
> 
>  
> 
> Andreas Fink
> 
>  
> 
> Fink Consulting GmbH
> 
> Global Networks Schweiz AG
> 
> BebbiCell AG
> 
>  
> 
> ---------------------------------------------------------------
> 
> Tel: +41-61-6666330 Fax: +41-61-6666331  Mobile: +41-79-2457333
> 
> Address: Clarastrasse 3, 4058 Basel, Switzerland
> 
> E-Mail:  [email protected]
> 
> www.finkconsulting.com www.global-networks.ch www.bebbicell.ch
> 
> ---------------------------------------------------------------
> 
> ICQ: 8239353 MSN: [email protected] AIM: smsrelay Skype: andreasfink
> 
> Yahoo: finkconsulting SMS: +41792457333

-- 
Thanks,
Alex