Re: Patch for supporting TYPE=USER for PPG

Alexander Malysh <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
Hi,

patch looks good, but please redo it with your cleanup and check coding
style.

Georg von Zezschwitz wrote:

> Georg von Zezschwitz schrieb:
>> Hi,
>>
>> attached is the patch for the feature I suggested some days ago.
> 
> Upps, I forgot one cleanup:
> 
> Index: gw/wap_push_pap_compiler.c
> ===================================================================
> RCS file: /home/cvs/gateway/gw/wap_push_pap_compiler.c,v
> retrieving revision 1.35
> diff -u -r1.35 wap_push_pap_compiler.c
> --- gw/wap_push_pap_compiler.c        7 Jan 2007 23:52:58 -0000       1.35
> +++ gw/wap_push_pap_compiler.c        19 Apr 2007 08:59:08 -0000
> @@ -1488,11 +1488,15 @@
>   *           -2, address parsing error
>   */
>  
> +extern List *ppg_user_rewrite;
> +
> 
> 
> That one is useless and should not be committed....
> 
> Georg

-- 
Thanks,
Alex
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.