Re: Patch for supporting TYPE=USER for PPG
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | Kannel Software Foundation (KSF) |
| Message-ID | <[email protected]> |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Georg von Zezschwitz wrote:
> Could you give me a hint, if I have overseen anything?
> (Found: Comment style, brace placement for functions)
Hi Georg,
looks ok to me, while untested at this point from my side.
+0 for commiting, some comments:
I know I should know, since I put all that PCRE stuff inside, but you seem to be
closed to the material at this point: Is the substitution syntax working for
POSIX.1 regex *and* PCRE? I recall POSIX.1 regex not beeing able to do substitutes?
Stipe
- -------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany
tolj.org system architecture Kannel Software Foundation (KSF)
http://www.tolj.org/ http://www.kannel.org/
mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org
- -------------------------------------------------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGJ1Vs9ez0oeKvYs0RAvFDAJwNNUvvaT8wIpNhc/hk3FQlDzxidACgpdhe
TIt4D9vVQ7zSxB1DO5M2hE4=
=IKTd
-----END PGP SIGNATURE-----