RE: req_feat patch

Hi Rene,

why not just define this parameter in send-url config variable?

Rene Kluwen wrote:

> There is a possibility to extract the value, given the MSG struct and
> it's members.
> Will that be a better option?
> I can come up with a version that does that. But before spending time on
> that, I want to know if it is an acceptable solution.
>  
> Rene Kluwen
> Chimit
> 
> -----Original Message-----
> From: Vincent CHAVANIS [mailto:[email protected]]
> Sent: woensdag 9 mei 2007 15:51
> To: [email protected]
> Subject: Re: req_feat patch
> 
> 
> -1 too for me as it.
>  
> * Hardcoded is bad
> * If we need to implement this we should set it as a config value.
>  
> Vincent
>  
> --
> Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR)
> Service Technique/Reseau - NOC
> Developpement SMS/MMS/Kiosques
> http://www.telemaque.fr/
> [email protected]
> Tel : +33 4 92 90 99 84 (fax 9142)
> 
> ----- Original Message -----
> From: Andreas  <mailto:[email protected]> Fink
> To: Rene Kluwen <mailto:[email protected]>
> Cc: [email protected]
> Sent: Wednesday, May 09, 2007 3:40 PM
> Subject: Re: req_feat patch
> 
> Clickatel is not a reference. If they introduce nonstandard parameters,
> its their problem.
> There is no reason to add this to kannel in that case.
> 
> And especially not something hardcoded like
> &req_feat=25151
> 
> So my vote is -10
> 
> On 09.05.2007, at 15:25, Rene Kluwen wrote:
> 
> 
> Nowadays, clickatell requires the req_feat parameter to enable to set
> the sender id or send binary SMS.
> 
> This patch enables this. Votes?
> 
> Rene Kluwen
> Chimit
> <req_feat.diff>
> 
> 
> 
> 
> 
> 
> Andreas Fink
> 
> 
> Fink Consulting GmbH
> Global Networks Schweiz AG
> BebbiCell AG
> 
> 
> ---------------------------------------------------------------
> Tel: +41-61-6666330 Fax: +41-61-6666331  Mobile: +41-79-2457333
> Address: Clarastrasse 3, 4058 Basel, Switzerland
> E-Mail:  [email protected]
> www.finkconsulting.com www.global-networks.ch www.bebbicell.ch
> ---------------------------------------------------------------
> ICQ: 8239353 MSN: [email protected] AIM: smsrelay Skype: andreasfink
> Yahoo: finkconsulting SMS: +41792457333

-- 
Thanks,
Alex