Re: [PATCH] Re: Bug: extract_msgdata_part_by_coding / message split

Hi,

why it should be necessary now? we have utf-8 internally and you can send
any gsm-03.38 chars via smsbox.

Stipe Tolj wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Alexander Malysh wrote:
> 
>> Hi Paco,
>> 
>> please find attached patch that should fix SMPP charset issue.
>> I don't know why there any GSM-03.38 comparisons because we don't use it
>> anywhere. So this peace of code was just plain wrong.
> 
> - -1, veto against Alex's patch for CVS comitting...
> 
> at least "temporary veto", I need to check in more detail here.
> 
> AFAIR, this compare was necessary to allow GSM-03.38 payload msg struct
> passing from smsbox->bearerbox while we had latin1 as internal encoding.
> Actually it was a kludge.
> 
> But need to check if it's really still necessary.
> 
> Stipe
> 
> - -------------------------------------------------------------------
> Kölner Landstrasse 419
> 40589 DÃŒsseldorf, NRW, Germany
> 
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
> 
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> - -------------------------------------------------------------------
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFGXzn99ez0oeKvYs0RAoFjAJ0YPLLQilhvjY5UCa7qLXQF0NoEVwCfalsF
> DhnYpmpdLOVNgnoRNxHkv/M=
> =UnyM
> -----END PGP SIGNATURE-----

-- 
Thanks,
Alex