Re: [PATCH] Include milliseconds in logging

ok,

You want just be more "flexible" but
i don't see here a real need to be flexible on this.
Even with ssl, localtime, keepalive, mutex, cookies options
(you are growing unecesserarily the data segment)

Then, in term of performances,
you will have the same result as a macro.

Vincent.


----- Original Message ----- 
From: "Stipe Tolj" <[email protected]>
Cc: <[email protected]>
Sent: Friday, January 11, 2008 4:37 PM
Subject: Re: [PATCH] Include milliseconds in logging


> Vincent CHAVANIS schrieb:
>>
>> Why do we need this ?
>> As we don't need to change it at start as we are not/are using localtime 
>> at start
>
> now, simple: your patch results in a "hard decission" for w/o milliseconds 
> at compile time. But we want a more flexible way via config diretive. In 
> order to have a fast runtime, we assign the function pointer while config 
> parsing to the desired w/o milliseconds function an keep running the same 
> call over runtime.
>
> My concern with the config directive was an unnecessary if statement 
> operation on EACH log event, but as the example shows, this can be easily 
> avoided by assigning the function pointer, and we still keep flexibility. 
> We could even switch while runtime via signaling or HTTP admin interface.
>
> Stipe
>
> -------------------------------------------------------------------
> Kölner Landstrasse 419
> 40589 Düsseldorf, NRW, Germany
>
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
>
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> -------------------------------------------------------------------
>
>