Fwd: Re: 100% cpu usage fix

Hi,

I've checked the CVS version and yes - CVS version doesn't have this problem.
Though I would change the do{}while loop with while{}do.
Currently privdata->shutdown condition is not checked when spinning in a loop 
retrying to connect.

--- smsc_at.c.orig      2008-01-09 22:06:52.000000000 +0200
+++ smsc_at.c   2008-02-09 17:45:54.000000000 +0200
@@ -1111,7 +1111,7 @@

 reconnect:

-    do {
+     while (!privdata->shutdown) {
         if (reconnecting) {
             if (conn->status == SMSCCONN_ACTIVE) {
                 mutex_lock(conn->flow_mutex);
@@ -1181,7 +1181,7 @@

         /* If we got here, then the device is opened */
         break;
-    } while (!privdata->shutdown);
+    }

     mutex_lock(conn->flow_mutex);
     conn->status = SMSCCONN_ACTIVE;


On Friday 08 February 2008, you wrote:
> Alexander Malysh schrieb:
> > Hi,
> >
> > I believe this commit fixed it in CVS:
> > 2007-10-05 Alexander Malysh <amalysh at kannel.org>
> >    * gw/smsc/smsc_at.c: reset reconnecting.
>
> Ernestas, can you confirm that you CAN reproduce the bug with CVS HEAD?
>
> Alex claims it has been fixed, see above.
>
> Stipe
>
> -------------------------------------------------------------------
> Kölner Landstrasse 419
> 40589 Düsseldorf, NRW, Germany
>
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
>
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> -------------------------------------------------------------------



-- 
BR,
Ernestas Vaiciukevičius
http://ernis.blogsite.org/

-------------------------------------------------------

-- 
BR,
Ernestas Vaiciukevičius
http://ernis.blogsite.org/