Re: PATCH: Postgresql Patch

Guillaume Cottenceau <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
Stipe Tolj <st 'at' tolj.org> writes:

> Guillaume Cottenceau schrieb:
>>
>> Can you show us the code? Difficult to make one's mind without
>> more information.
>>
>> I don't know the UUID thing but what may make a difference would
>> be a little performance penalty (inserting a value instead of
>> letting postgres handle the SERIAL its way). But it should be
>> minimal, I think.
>>
>> Also, let's not forget to document the importance of creating an
>> index on the UUID column, if we're going to select by UUID, which
>> I guess will be the case.
>
> the code is in gwlib/gw_uuid.[ch].

Ah (notice the header parts of these files should probably be
reworked a bit).

I was referring to the actual difference planned to use the UUID
stuff for DLRs. E.g. see what were your actual plans with using
that data; even if it's guessable at that point of the
discussion, it's always more precise and less error prone to see
the code rather than intentions :)

> Alex did a lot for research at the time he introduced the UUID
> implementation as a message ID for the transport layers in Kannel. And

That looks great, granted.

-- 
Guillaume Cottenceau, MNC Mobile News Channel SA, an Alcatel-Lucent Company
Av. de la Gare 10, 1003 Lausanne, Switzerland - direct +41 21 317 50 36
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.