RE: PATCH: only typedef int64 if type does not already exist

> From: Stipe Tolj [mailto:[email protected]]
> Sent: 10 July 2008 17:06
> 
> Bostock James schrieb:
> > Hi,
> >
> > The attached patch causes the int64 type to only be defined (in
> > gw/smsc/smsc_soap.c) if it does not already exist (as determined by
the
> > autoconf AC_CHECK_TYPES macro). This patch fixes a compilation
failure
> > on AIX when compiling in 64 bit mode.
> 
> first of all thanks a lot James, we appreciate your work highly.
> 
> hmmm, -0 on the patch. Reason: I don't like the idea to have
> 
>    #define HAVE_<TYPE>
> 
> statements in the gw-config.h.in autoconf macro.
> 
> The "mapping" of 32bit and 64bit integer/long should be done by the OS
> layer
> headers underneath /usr/include itself, IMO.
> 
> Any one other please comment on this issue. How does linux-x86_64 does
it
> for
> the referred gw/smsc/smsc_soap.c file?
> 

Fair enough.

How about instead of using the name int64, using a name less likely to
conflict with a name defined by the OS. Say, gw_int64?

-james