Re: PATCH: X25 speed (AIX does not define B115200)
Vincent CHAVANIS <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
++1. X.25 protocol is quite old, that means system will also be old. And that means we need to support most of these. FYI, POSIX.1 define at least B57600. Vincent Bostock James a écrit : >> From: Vincent CHAVANIS >> Sent: 10 July 2008 18:06 >> >> I'm +0 as it. >> >> The fact is that we need to choose the fastest available speed. >> But assume at lease a default working speed as 9600bps >> >> Could you please modify your patch and submit it again? >> >> thanks! >> >> Vincent >> > > Speeds of up to B38400 are defined by the Single UNIX Specification > (http://www.opengroup.org/onlinepubs/007908799/xsh/termios.h.html) so I > am not sure whether it is necessary to check for each constant from > B9600 up to B115200 (by the way, does anyone know why B115200 is used > and not one of the higher speeds that seemed to be defined in termios.h > on operating systems other than AIX 5.2?). > > However, if this will make the difference between my patch being > accepted or rejected, the updated patch (attached) does this. > > -james -- Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR) Service Technique/Reseau - NOC Direction du Developpement xMS+ http://www.telemaque.fr/ [email protected] Tel : +33 4 92 90 99 84 (fax 9142)