Re: [PATCH] MO routing: smsbox-route with keywords

Hi,

Illimar Reinbusch - Telejazz.com schrieb:
> Hi
> 
> This patch was originally developed by me to add support for our needs 
> and we really needed that to work fast. We have tested it with very high 
> speeds and it had no impact on bearerbox delivery speeds.
> 
> I agree that the code isnt very clean and im going to update it this 
> week to provide cleaner output.
> 
> Alex can u explain your -1 on your side?

 >> I don't like to see code duplication with smsbox on keyword mapping.
 >> It would be great to be able to use urltrans's keyword mapping for
 >> smsbox routing.


> 
> Illimar Reinbusch
> 
> 
>> Hi Stipe,
>>
>> -1 for this patch as is. +1 for the idea to be able to route messages 
>> based on keyword to specific smsbox.
>> I don't like to see code duplication with smsbox on keyword mapping.
>> It would be great to be able to use urltrans's keyword mapping for 
>> smsbox routing.
>>
>> Thanks,
>> Alex
>>
>> Stipe Tolj schrieb:
>>> Hi list,
>>>
>>> please find attached a patch against current CVS HEAD to add support for
>>> keyword/alias based smsbox instance MO routing.
>>>
>>> This patch was provided by a user. Unfortunately I can't recall which 
>>> one it
>>> was, so please feel free to "recall me" on this, so the appropriate 
>>> people get
>>> their credits in the ChangeLog. :)
>>>
>>> What it allows is using this for bearerbox's MO routing towards a 
>>> connected
>>> smsbox instance:
>>>
>>>   group = smsbox-route
>>>   ...
>>>   keyword = <keyword>
>>>   aliases = "<alias1>;<alias2>;...;<aliasN>"
>>>   smsbox-id = foobar
>>>
>>> which will ensure (in combination if used with the other 2 
>>> directives, 'smsc-id'
>>> and 'shortcode') that any MO with the associated keywords are routed 
>>> to the
>>> 'smsbox-id' identified smsbox instance.
>>>
>>> Please review and vote for commit to CVS.
>>>
>>> Stipe
>>>
>>>
>>
>>
> 
> 
>