Re: [PATCH] MO routing: smsbox-route with keywords

Stipe Tolj schrieb:
> Illimar Reinbusch - Telejazz.com schrieb:
>> Hi
>>
>> This patch was originally developed by me to add support for our needs
>> and we really needed that to work fast. We have tested it with very high
>> speeds and it had no impact on bearerbox delivery speeds.
>>
>> I agree that the code isnt very clean and im going to update it this
>> week to provide cleaner output.
>>
>> Alex can u explain your -1 on your side?
> 
> Alex is pedantic usually. Some experience this as "annoying", but generally it's
> "protective" and makes sense. ;)

maybe ;)

The idea is as follows: we have urltrans where the whole keyword 
handling magic already implemented and maintained. Then why should we 
implement keyword mapping again in bb_boxc if we could reuse urltrans 
logic or just extract keyword mapping logic from urltrans and use 
extracted code in both bb_boxc and urltrans.

Hope now it's clear what I mean?


> 
> Illimar, sorry for missing the source. As mentioned in the PATCH mail, I simply
> didn't recall.
> 
> Please if you have the time and want to contribute, please take Alex's
> suggestion and work on the patch (please against CVS HEAD, not meta-data branch ;)
> 
> Stipe
>