Re: [PATCH] Get all available TLV's as Meta-Data

Hi Alex,

great!!! :)

Could you please change this patch to use dictionary tlv_by_tag because 
the name of configured TLV may be different of the one in SMPP spec. but 
the tag will be equal. I think it's up to user which name configured TLV 
should use.

And minor issue: please always make patches from gateway root directory 
with cvs diff -Nau.

Thanks,
Alex

Alejandro Guerrieri schrieb:
> Hi,
> 
> This patch allows meta-data to carry all available TLV's not only the 
> User-Defined.
> 
> All TLV's defined on smpp_pdu.def were "hijacked" by the main pdu 
> structure, so they never reached the tlv dictionary. What this patch 
> does is to check for defined TLV's on the smpp-tlv group and copy them 
> to the tlv dictionary. Those TLV's are then available on the meta-data 
> parameter.
> 
> It only copies the TLV's explicitly defined, otherwise the meta-data 
> parameter would be unnecessary cluttered with all available TLV's.
> 
> This solves the "receipted_message_id" issue with deliver_sm (to name 
> one), but does _not_ solve the "message_id" param on 
> submit/deliver/data_sm_response, since message_id is not a TLV.
> 
> For that parameter I could add a call for meta_data_set_value to inject 
> it into the meta data (already tried and works), but then it would be 
> always available.
> 
> To avoid this, I could use the same filtering mechanism as with the 
> TLV's, but that would mean defining a dummy tag address, since this is 
> not a TLV so it doesn't have a documented address. I could filter using 
> tag_by_name, so the address wouldn't matter anyways, but it's somewhat 
> ugly imho.
> 
> Ideas? Opinions?
> 
> Regards,
> -- 
> Alejandro Guerrieri
> [email protected]
> 
> 
> 
>