Re: [PATCH] Location header recovering to absoluteURI
"Nikos Balkanas" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <000501c97f1b$0f97a210$02b2a8c0@tardis> |
There is no problem with the list. I got both of your mails OK. Additionally you obviously receive list messages. BR, Nikos ----- Original Message ----- From: "Martin Conte Mac Donell" <[email protected]> To: "Stipe Tolj" <[email protected]> Cc: "kannel_dev_mailinglist" <[email protected]> Sent: Sunday, January 25, 2009 7:39 PM Subject: Re: [PATCH] Location header recovering to absoluteURI >I think this email doesn't arrive to the list. here we go again: > > I'm just visiting here since i've got an insanely amount of work, but > i'v two comments. > > 1) Eclipse?, really? > > 2) I'm not pretty sure about "if (trans->port != 80)", it'll work fine > in most cases but there is a border case when it'll not (Yeah, i know. > I'm anal), the case is when you are going through ssl by port 80 (Yeah > ok, shouldn't happen but you never know). I think the safest way is > append port number always, it won't hurt anyway. > > M. > > > On Fri, Jan 23, 2009 at 6:10 PM, Martin Conte Mac Donell > <[email protected]> wrote: >> On Fri, Jan 23, 2009 at 3:15 PM, Stipe Tolj <[email protected]> wrote: >>> Hi list, >>> >>> we refuse to follow party defined absoluteURI Location header values. >>> Which is >>> "correct" when being pedantic with the specs. But some mayor HTTP >>> services, i.e. >>> Yahoo do send URI /xxx as Location header values. This patch ensures we >>> are able >>> to recover from this circumstance, and continue the following. >>> >>> Please review, test and vote for committing to CVS HEAD. >>> >>> Stipe >