Re: [PATCH] Location header recovering to absoluteURI

Considering that this is very minor (only in the /xyz cases, estimate ~20% 
of that to be SSL), I am happy with it.

BR,
Nikos
----- Original Message ----- 
From: "Stipe Tolj" <[email protected]>
Cc: <[email protected]>
Sent: Monday, January 26, 2009 5:33 PM
Subject: Re: [PATCH] Location header recovering to absoluteURI


> Nikos Balkanas schrieb:
>> Hold on,
>>
>> I agree completely with you in terms of performance, but the if
>> statement is not correct the way it stands. Shouldn't it be?
>>
>>
>> if (!((!trans->ssl && trans-port == 80) || (trans-ssl && trans-port ==
>> 443)))
>>   octstr_format_append(os, ":%ld", trans->port);
>
> I have committed it this way:
>
>        /* port, only added if literally not default. */
>        if (trans->port != 80 || trans->ssl) {
>            octstr_format_append(os, ":%ld", trans->port);
>        }
>
> which simply ensures we don't omit the port 80 in case of SSL'ed conn. If 
> we
> have a normal https:// scheme with port 443, we'll include the port. But 
> as this
> is a "much less likely" case, I think we shouldn't do the checks in the if
> statement for all.
>
> Stipe
>
>
> -- 
> -------------------------------------------------------------------
> Kφlner Landstrasse 419
> 40589 DΟsseldorf, NRW, Germany
>
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
>
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> -------------------------------------------------------------------
>