Re: [PATCH] Fixing SMPP re-routing, DLR request indication

Hi,

AFAIK deliver_sm.registered_delivery may contain values: 4, 8, 12 only.
Also 1 and 2 are wrong in the patch.
The second thing is, that ESME/SME DLRs contains only ACKs.

Short to say: as from the smpp spec perspective -1

For the SMPP based re-routing I don't see any sense to forward DLR flags 
without a SMPP based DLR re-routing possibility, means submit_sm for 
ESME/SME ACKs should be also implemented.

Thanks,
Alex

P.S. Saw anybody deliver_sm.registered_delivery set from real SMSC in 
the wild? If so how submit_sm with ACK should look like?

Stipe Tolj schrieb:
> Hi list,
> 
> as David Chkhartisvili has reported on 2008-10-29, we don't proxy correctly the
> DLR request indication when doing SMPP based re-routing of MOs to MTs. We simply
> omit any deliver_sm.registered_delivery value.
> 
> Please find attached a simple patch, that ensures we handle the value in the
> pdu_to_msg() function, so that a later re-routing and re-injection to the smsc
> routing can take care of the DLR mask and re-apply the registered_delivery value.
> 
> Please have a fast glance and vote.
> 
> Thanks,
> Stipe
> 
>