Re: Patch removed from CVS

the issue is that we always paniced when %llu was used because  
octstr_format doesn't implement %llu format.

Thanks,
Alex

P.S. You are free to implement %llu for octstr_format then I will  
reapply my smpp patch ;)

Am 28.01.2009 um 12:09 schrieb Nikos Balkanas:

> Interesting. This is just correct C for printing strtoll. Seems that  
> in this case 2 wrongs make it right. Any chance that SMPP dlr  
> handling can be corrected? I imagine that all 32bit machines with  
> smpp connections would have this problem.
>
> BR,
> Nikos
> ----- Original Message -----
> From: Alexander Malysh
> To: Nikos Balkanas
> Cc: [email protected]
> Sent: Wednesday, January 28, 2009 10:13 AM
> Subject: Re: Patch removed from CVS
>
> Hi,
>
> this is OK, I have dropped this patch because it break SMPP dlr  
> handling.
>
> Am 28.01.2009 um 01:10 schrieb Nikos Balkanas:
>
>> Hi,
>>
>> I just tried to update from CVS. A lot of work has been introduced  
>> for meta-data recently. Unfortunately, in the case of gw/smsc/ 
>> smsc_smpp.c it seems old sources were used, with the result that  
>> the llu patch commited by Alex for bug #460 has disappeared. Alex,  
>> can you recommit please?
>>
>> From: "Alexander Malysh" <[email protected]>
>> To: <[email protected]>
>> Sent: Friday, January 09, 2009 5:05 PM
>> Subject: [PATCH] Bug 460
>>
>>
>> > Hi All,
>> >
>> > here is proposed patch to fix #460.
>> >
>> > any objections to commit it?
>> >
>> > Thanks,
>> > Alex
>> >
>>
>>
>> --------------------------------------------------------------------------------
>>
>>
>> > diff --git a/gw/smsc/smsc_smpp.c b/gw/smsc/smsc_smpp.c
>> > index d81132c..b6f8cb0 100644
>> > --- a/gw/smsc/smsc_smpp.c
>> > +++ b/gw/smsc/smsc_smpp.c
>> > @@ -1278,9 +1278,9 @@ static Msg *handle_dlr(SMPP *smpp, Octstr
>> > *destination_addr, Octstr *short_messa
>> >         } else {
>> >             if ((smpp->smpp_msg_id_type & 0x02) ||
>> >                 (!octstr_check_range(msgid, 0, octstr_len(msgid),
>> > gw_isdigit))) {
>> > -                tmp = octstr_format("%lu",
>> > strtoll(octstr_get_cstr(msgid), NULL, 16));
>> > +                tmp = octstr_format("%llu",
>> > strtoll(octstr_get_cstr(msgid), NULL, 16));
>> >             } else {
>> > -                tmp = octstr_format("%lu",
>> > strtoll(octstr_get_cstr(msgid), NULL, 10));
>> > +                tmp = octstr_format("%llu",
>> > strtoll(octstr_get_cstr(msgid), NULL, 10));
>> >             }
>> >         }
>> >
>> >
>
>