Re: Patch removed from CVS

looks ok to me but could you please fix coding style. e.g.

if (bla) {
     ggg
} else {
     xxx
}

the same for:

switch(bla) {
case x:
     lll
case y:
    bbb
}

Thanks,
Alex

Am 29.01.2009 um 01:59 schrieb Nikos Balkanas:

> You are absolutely right. Couldn't figure out the logic behind the  
> existing type casting. I believe that now it is OK.
>
> BR,
> Nikos
> ----- Original Message ----- From: "Martin Conte Mac Donell" <[email protected] 
> >
> To: "Nikos Balkanas" <[email protected]>
> Cc: "Alexander Malysh" <[email protected]>; <[email protected]>
> Sent: Thursday, January 29, 2009 2:00 AM
> Subject: Re: Patch removed from CVS
>
>
>> On Wed, Jan 28, 2009 at 8:58 PM, Nikos Balkanas  
>> <[email protected]> wrote:
>>> Hi all,
>>>
>>> Attached patch to gwlib/octstr.c provides support for %ll and %llu  
>>> in
>>> octstr_format. To do that I introduced a new format->type: 'L' for  
>>> long long
>>> variables. This is a prerequisite patch for #460.
>>>
>>> Please vote, and if possible test (I have tested it only with my  
>>> demo
>>> program, not kannel).
>>>
>>> BR,
>>> Nikos
>>
>> Why default cases are casted to (short) and (unsigned short)  
>> respectively?
>>
>> Also format->prec is already long, so you don't need:
>>
>> +            n = (long) format->prec;
>>
>> M
> <patch.diff>