Re: [PATCH] fixes compiler warning on /test/test_octstr_format.c

Yep, apparently it is.

BR,
Nikos
----- Original Message ----- 
From: "Martin Conte Mac Donell" <[email protected]>
To: "Nikos Balkanas" <[email protected]>
Cc: <[email protected]>; <[email protected]>
Sent: Thursday, February 12, 2009 2:52 AM
Subject: Re: [PATCH] fixes compiler warning on /test/test_octstr_format.c


> On Wed, Feb 11, 2009 at 9:54 PM, Nikos Balkanas <[email protected]> 
> wrote:
>> Hi,
>>
>> I don't think that the ull suffix is needed. The variable is casted
>> correctly from the equality. Just the number is enough.
>
> It is not enough and variable is not "casted", "the number" is a
> constant. If you don't put this sufix you COULD get warnings like
>
> """
> integer constant is so large that it is unsigned
> this decimal constant is unsigned only in ISO C90
> integer constant is too large for 'long' type
> """
>
> M.