Re: gwlib/charset patch

Hi,

Nope. This is the function prototype from include/iconv.h:

extern LIBICONV_DLL_EXPORTED size_t iconv (iconv_t cd, const char* * inbuf, 
size_t *inbytesleft, char* * outbuf, size_t *outbytesleft);

Note the 2nd argument, const char* * inbuf. This is what makes gcc 3.4.3 
(stock solaris 10) to complain. This is from iconv sources 1.12, general not 
solaris or linux specific and outside any OS related preprocesor 
definitions.

Could be that newer gcc doesn't complain about (const char) -> (char) 
conversions, but even if it doesn't, it doesn't hurt to be compatible to the 
function declaration, and make Solaris and OSX folks happy. :-)

BR,
Nikos
----- Original Message ----- 
From: "Alexander Malysh" <[email protected]>
To: <[email protected]>
Sent: Monday, March 02, 2009 12:53 AM
Subject: Re: gwlib/charset patch


> Hi,
>
> nope, it doesn't fix it for all, just for OSX and Solaris. Here is linux 
> version:
>        size_t iconv(iconv_t cd,
>                     char **inbuf, size_t *inbytesleft,
>                     char **outbuf, size_t *outbytesleft);
>
> Thanks,
> Alex
>
> Nikos Balkanas schrieb:
>> Hi,
>>  Just a simple patch to get rid of that pesky iconv compiler warning. 
>> Couldn't stand it any more :-)
>>  Enjoy,
>> Nikos
>
>